Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
==========================================
+ Coverage 41.98% 42.02% +0.03%
==========================================
Files 47 47
Lines 2751 2751
==========================================
+ Hits 1155 1156 +1
+ Misses 1596 1595 -1 ☔ View full report in Codecov by Sentry. |
ceholden
reviewed
Mar 12, 2025
Collaborator
ceholden
left a comment
There was a problem hiding this comment.
+1 to the design in general, especially as the DuckDB config has all of these in the same place
gadomski
commented
Mar 12, 2025
ceholden
approved these changes
Mar 12, 2025
Collaborator
ceholden
left a comment
There was a problem hiding this comment.
Thanks! I think this looks great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ceholden this is a bit of a simpler implementation. I wasn't finding a
fetch_extensionssetup that felt right to me. I tested locally by deleting my extensions and running just theno_installtest and it failed 🥳