Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix datetime validator #662

Merged
merged 3 commits into from
Apr 18, 2024
Merged

fix datetime validator #662

merged 3 commits into from
Apr 18, 2024

Conversation

jonhealy1
Copy link
Collaborator

@jonhealy1 jonhealy1 commented Apr 18, 2024 •
edited
Loading

Related Issue(s):

Description:

The str_to_interval function is not allowing datetime = None values which is preventing GET /search requests from working if no datetime value is specified. ex. this request would fail: http://localhost:8080/search?bbox=178,-73,180,-71

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@jonhealy1 jonhealy1 merged commit 1148c9d into main Apr 18, 2024
7 checks passed
@jonhealy1 jonhealy1 deleted the str_to_interval-fix branch April 18, 2024 15:03
@jonhealy1 jonhealy1 mentioned this pull request Apr 18, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonhealy1 @vincentsarago