Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply datetime converter in ItemCollection endpoint model #667

Merged
merged 2 commits into from
Apr 22, 2024
Merged

apply datetime converter in ItemCollection endpoint model #667

merged 2 commits into from
Apr 22, 2024

Conversation

StijnCaerts
Copy link
Contributor

@StijnCaerts StijnCaerts commented Apr 22, 2024 •
edited
Loading

Related Issue(s):
N/A

Description:
Right now, the datetime converter is only applied in the BaseSearchGetRequest model, but not in the ItemCollectionUri model. This PR adds the converter to the last one, aligning the parameter handling.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

jonhealy1
jonhealy1 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@vincentsarago vincentsarago self-requested a review April 22, 2024 12:33
@jonhealy1 jonhealy1 merged commit dddd710 into stac-utils:main Apr 22, 2024
7 checks passed
@StijnCaerts StijnCaerts mentioned this pull request Apr 22, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

@vincentsarago vincentsarago vincentsarago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StijnCaerts @vincentsarago @jonhealy1