Remove multihashes dependency #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `multihashes` library is deprecated. `multiformats` could be used instead, but it's an ESM only library. ESM modules do not work well with jest. Hence a minimal implementation without any dependencies is used instead. It could be considered a breaking change as the API of `Migrate.enableMultihash()` changed. It longer takes the `multihashes` library as parameter, but no value at all. Though passing it in won't do any harm, so it's kind of backwards compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
multihasheslibrary is deprecated.multiformatscould be used instead, but it's an ESM only library. ESM modules do not work well with jest. Hence a minimal implementation without any dependencies is used instead.It could be considered a breaking change as the API of
Migrate.enableMultihash()changed. It longer takes themultihasheslibrary as parameter, but no value at all. Though passing it in won't do any harm, so it's kind of backwards compatible.