-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fetch extensions #681
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
==========================================
+ Coverage 41.98% 42.02% +0.03%
==========================================
Files 47 47
Lines 2751 2751
==========================================
+ Hits 1155 1156 +1
+ Misses 1596 1595 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to the design in general, especially as the DuckDB config has all of these in the same place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this looks great
@ceholden this is a bit of a simpler implementation. I wasn't finding a
fetch_extensions
setup that felt right to me. I tested locally by deleting my extensions and running just theno_install
test and it failed 🥳