add action to attach lambda zips to release #1015
Conversation
theodorehreuter
left a comment
theodorehreuter
left a comment
There was a problem hiding this comment.
minor tweaks, approved to unblock
| on: | ||
| release: | ||
| types: | ||
| - published |
There was a problem hiding this comment.
lets add a tag validator too like tags: ['v.*.*.*] so this is only getting run on proper releases that are versioned correctly not just any old tag. Maybe that's not quite the intent but adding only to official releases seems logical.
There was a problem hiding this comment.
Actually, it looks like the tags filter is only available for the push event: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax. release only supports the types filter.
| - name: Get node version | ||
| run: echo "NODE_VERSION=$(cat .nvmrc)" >> "$GITHUB_ENV" | ||
| - name: Get stac-server version | ||
| run: echo "STAC_SERVER_VERSION=$(npm pkg get version | tr -d '\"')" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
can we get this from the tag being created instead ala github.ref_name? If you opted to go that way.
There was a problem hiding this comment.
Oh, very good call, that cleans the workflow up a lot actually!
2 participants
Proposed Changes:
PR Checklist: