Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set mapping for proj:transform #759

Merged
merged 3 commits into from
May 7, 2024
Merged

set mapping for proj:transform #759

merged 3 commits into from
May 7, 2024

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

  • n/a

Proposed Changes:

  1. For the first item indexed in a new collection, if all values in the
    proj:transform array were integers, the values were typed as integers,
    which would then cause an error for subsequent items that had float values
    in the array.

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner changed the title Pv/mapping set mapping for proj:transform May 6, 2024
@philvarner philvarner requested review from pjhartzell and ircwaves and removed request for pjhartzell May 6, 2024 19:18
Copy link
Member

@ircwaves ircwaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@philvarner philvarner merged commit c8282a0 into main May 7, 2024
3 checks passed
@philvarner philvarner deleted the pv/mapping branch May 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants