Support multiple Layers in WMTS endpoint #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Aug 31, 2023
| loader=jinja2.ChoiceLoader( | ||
| [ | ||
| jinja2.PackageLoader(__package__, "templates"), | ||
| jinja2.PackageLoader("titiler.core", "templates"), |
There was a problem hiding this comment.
We need this because we are using a modified version of the wmts.xml file from titiler
vincentsarago
commented
Aug 31, 2023
vincentsarago
commented
Aug 31, 2023
vincentsarago
commented
Sep 4, 2023
TODO
|
geospatial-jeff
approved these changes
Sep 5, 2023
vincentsarago
commented
Sep 5, 2023
CHANGES.md
Outdated
| @@ -1,8 +1,9 @@ | |||
| # Release Notes | |||
|
|
|||
| ## 0,5,2 (TDB) | |||
| ## 0.5.2 (TDB) | |||
There was a problem hiding this comment.
I think this should be a minor version update because it's really breaking the WMTSCapatibilities endpoint (removed the openapi schemas for dependencies and return xml with multiple layers)
vincentsarago
changed the title
vincentsarago
commented
Sep 6, 2023
| self.render_dependency, | ||
| PgSTACParams, | ||
| self.reader_dependency, | ||
| ] |
There was a problem hiding this comment.
We now check all the tiles dependencies
vincentsarago
commented
Sep 6, 2023
|
@geospatial-jeff could you have a last look before we merge? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar as #120 but within the wmts endpoints
This is blocked for now because:This remove any query-parameter check (assets) in the endpointTesting locally (in QGIS) didn't work, for some reason it request URL with a weird encodingcc @geospatial-jeff
Note: This will be quite a breaking change for the wmts endpoint so It's not 💯 sure that it will get merged, but maybe added as an extension or an example in the documentation