Allow pgstac parameters for geojsonsearch to be globally set in Settings #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes #185. I have created a Settings object so the parameters to PgStac's
geojsonsearch
can be set globally via environment variables. I added an example to.env.example
as well so hopefully it is clear how to set them. These can still also be set via query params.Tests
I ran locally and made sure any change to these pgstac env variables would apply to any request I made. I then made sure I could pass in query params to a specific request and just that request would use that change. I confirmed those both by adding print statements in the code here, and working with my data that had issues when
existwhenfull
andskipcovered
were both True. So easy for me to visually ensure what I expected to happen would happen.