Add patch_url kwarg for signing hrefs and objects#31
Merged
Conversation
Member
Author
|
@gadomski do you have an opinion on this? |
gadomski
reviewed
Sep 22, 2023
Member
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Yeah, running everything through planetary_computer.sign doesn't really scale in the long run (do we add every big provider's signing package to the chain?) so I'm 👍🏼.
jsignell
changed the title
pass_urls kwarg for assetspatch_urls kwarg for assets
jsignell
changed the title
patch_url kwarg forpatch_url kwarg for signing hrefs and objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like potentially a better approach than just signing everything but it would be great to get a second opinion
closes #29