-
Notifications
You must be signed in to change notification settings - Fork 4
implementation for archive extension #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for opening a PR @kmodali! It might take me a few days to get around to reviewing, but it is on my list! |
jsignell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recognize that this PR might be in a partial state, but now that I've (finally!) read it over I feel pretty convinced that this logic doesn't belong in xpystac. It should be the responsibility of the zarr backend to make sense of an archived zarr file. So while xpystac might need to add a little logic to understand how to hand off metadata from the archive extension fields it shouldn't be in charge of any caching or extracting.
| default_kwargs: Mapping = {"chunks": {}} | ||
|
|
||
| # Check the type of the 'obj' | ||
| if isinstance(obj, pystac.Asset): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should always evaluate to true since this function is registered for the case where obj is an Asset.
…te basic usage of 'archiveextension'
|
@jsignell Thank you very much for reviewing this PR and providing valuable suggestions. Subsequently the corresponding changes for 'archiveextension' have been made. Also the scope of this PR now extends across zarr-python , xpystac and pystac. zarr-python
pystac
xpystac
|
zarr-python ( update )
|
|
Thanks for writing this up @kmodali. When adding new code to this repo it should have tests that look like those in https://github.com/stac-utils/xpystac/tree/main/tests |
|
@jsignell Added 'tests/test_archiveextension.py' as suggested. Thank you. |
Handling STAC items with tar assets, either single tar or list of tars.