Merged
Conversation
maltesander
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
maltesander
requested changes
Apr 16, 2025
Member
maltesander
left a comment
maltesander
left a comment
There was a problem hiding this comment.
First batch, tests work fine, will do some more manual testing.
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
nightkr
reviewed
Apr 28, 2025
Member
Author
|
Re-ran tests locally: 🟢 |
nightkr
reviewed
Apr 29, 2025
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
sbernauer
reviewed
Apr 29, 2025
Member
|
Thanks @adwk67 for addressing the changes from the ADR! I didn't look at the code, as @maltesander and @nightkr already did, but installed the operator and tried it out. Small notes on what I checked: Services now look good! They match the decision https://github.com/stackabletech/decisions/issues/51: ➜ airflow-operator git:(feat/integrate-listener-operator) ✗ k get svc | grep airflow kind-kind
airflow-scheduler-default-metrics ClusterIP None <none> 9102/TCP 3m1s
airflow-webserver-default NodePort 10.96.33.78 <none> 8080:30139/TCP 3m1s
airflow-webserver-default-metrics ClusterIP None <none> 9102/TCP 3m1s
airflow-worker-default-metrics ClusterIP None <none> 9102/TCP 3m1sstacklet list looks nice, the metrics are not shown any more (which is fine I'd say): ➜ airflow-operator git:(feat/integrate-listener-operator) ✗ stackablectl stacklet list kind-kind
┌─────────┬─────────┬───────────┬─────────────────────────────────────────────────┬─────────────────────────────────┐
│ PRODUCT ┆ NAME ┆ NAMESPACE ┆ ENDPOINTS ┆ CONDITIONS │
╞═════════╪═════════╪═══════════╪═════════════════════════════════════════════════╪═════════════════════════════════╡
│ airflow ┆ airflow ┆ default ┆ webserver-default-http http://172.18.0.2:30139 ┆ Available, Reconciling, Running │
└─────────┴─────────┴───────────┴─────────────────────────────────────────────────┴─────────────────────────────────┘I can also sprinkle in some more rolegroups, looks good: ➜ airflow-operator git:(feat/integrate-listener-operator) ✗ k get svc | grep airflow kind-kind
airflow-scheduler-default-metrics ClusterIP None <none> 9102/TCP 7m55s
airflow-webserver-big NodePort 10.96.43.47 <none> 8080:31748/TCP 15s
airflow-webserver-big-metrics ClusterIP None <none> 9102/TCP 15s
airflow-webserver-default NodePort 10.96.33.78 <none> 8080:30139/TCP 7m55s
airflow-webserver-default-metrics ClusterIP None <none> 9102/TCP 7m55s
airflow-worker-default-metrics ClusterIP None <none> 9102/TCP 7m55s
airflow-worker-with-gpu-metrics ClusterIP None <none> 9102/TCP 15s┌─────────┬─────────┬───────────┬─────────────────────────────────────────────────┬────────────────────────────────────────────┐
│ PRODUCT ┆ NAME ┆ NAMESPACE ┆ ENDPOINTS ┆ CONDITIONS │
╞═════════╪═════════╪═══════════╪═════════════════════════════════════════════════╪════════════════════════════════════════════╡
│ airflow ┆ airflow ┆ default ┆ webserver-big-http http://172.18.0.2:31748 ┆ Unavailable: See [1], Reconciling, Running │
│ ┆ ┆ ┆ webserver-default-http http://172.18.0.2:30139 ┆ │
└─────────┴─────────┴───────────┴─────────────────────────────────────────────────┴────────────────────────────────────────────And the metrics services have the correct scrape label: ➜ airflow-operator git:(feat/integrate-listener-operator) ✗ k get svc -l prometheus.io/scrape=true kind-kind
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
airflow-scheduler-default-metrics ClusterIP None <none> 9102/TCP 17m
airflow-webserver-big-metrics ClusterIP None <none> 9102/TCP 9m56s
airflow-webserver-default-metrics ClusterIP None <none> 9102/TCP 17m
airflow-worker-default-metrics ClusterIP None <none> 9102/TCP 17m
airflow-worker-with-gpu-metrics ClusterIP None <none> 9102/TCP 9m56sAfterwards I ran Metrics show up, e.g. shows all 8 Pods produce metrics: |
Member
Author
Thanks - jenkins run, and a new issue to re-visit various things mentioned above: stackabletech/issues#734 Ran it again on a manually-provisioned replicated k3s cluster: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes: #580
Jenkins tests 🟢
Openshift tests 🟢 (logging test passed when run again in isolation)
Tests after https://github.com/stackabletech/decisions/issues/51 changes: 🟢 Jenkins
Definition of Done Checklist