Skip to content

chore: Fix listenerClass references in tests and docs #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented May 26, 2025

Description

Updating tests and docs according to CRD change

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@sbernauer sbernauer self-assigned this May 26, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering May 26, 2025
@sbernauer
Copy link
Member Author

@adwk67 adwk67 self-requested a review May 27, 2025 10:23
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 27, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. LGTM!

@sbernauer
Copy link
Member Author

Thanks!

@sbernauer sbernauer added this pull request to the merge queue May 27, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 27, 2025
Merged via the queue into main with commit ab05674 May 27, 2025
28 of 30 checks passed
@sbernauer sbernauer deleted the chore/fix-listenerclass-references branch May 27, 2025 12:06
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants