Skip to content

chore: Remove hardcoded uid and gid #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Jun 2, 2025

Description

Part of stackabletech/issues#651

Remove hardcoded uid and gid, they'll default to the ones from the docker images now.
For 25.7 that means they might change from 1000/0
See stackabletech/docker-images#916 for details

I needed to increase the limits for some tests to get them to work but haven't included that in this PR.

This depends on stackabletech/docker-images#1138 so that one needs to be merged first.

Definition of Done Checklist

Author

  • Integration tests passed (for non trivial changes)

Reviewer

  • Changelog updated

Acceptance

  • Proper release label has been added

@lfrancke lfrancke force-pushed the feat/hardcoded-uid-gid branch from ad434d1 to e51b0b8 Compare June 2, 2025 10:05
@lfrancke lfrancke self-assigned this Jun 2, 2025
@lfrancke lfrancke marked this pull request as ready for review June 2, 2025 10:06
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Jun 2, 2025
@adwk67 adwk67 self-requested a review June 2, 2025 12:16
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 2, 2025
@adwk67
Copy link
Member

adwk67 commented Jun 4, 2025

Local tests following merge from main:

--- PASS: kuttl (2492.82s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/overrides_airflow-latest-3.0.1_openshift-false (289.23s)
        --- PASS: kuttl/harness/smoke_airflow-3.0.1_openshift-false_executor-celery (324.60s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.0.1_openshift-false_executor-celery (213.55s)
        --- PASS: kuttl/harness/external-access_airflow-3.0.1_openshift-false_executor-kubernetes (196.28s)
        --- PASS: kuttl/harness/external-access_airflow-3.0.1_openshift-false_executor-celery (207.01s)
        --- PASS: kuttl/harness/oidc_airflow-latest-3.0.1_openshift-false (205.17s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.0.1_ldap-authentication-insecure-tls_openshift-false_executor-kubernetes (142.37s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.0.1_openshift-false_executor-kubernetes (217.64s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.0.1_ldap-authentication-server-verification-tls_openshift-false_executor-kubernetes (154.09s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.0.1_ldap-authentication-server-verification-tls_openshift-false_executor-celery (181.33s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.0.1_ldap-authentication-no-tls_openshift-false_executor-kubernetes (156.01s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.0.1_ldap-authentication-no-tls_openshift-false_executor-celery (189.16s)
        --- PASS: kuttl/harness/opa_airflow-non-experimental-2.10.5_opa-latest-1.4.2_openshift-false (154.90s)
        --- PASS: kuttl/harness/logging_airflow-3.0.1_openshift-false_executor-celery (397.35s)
        --- PASS: kuttl/harness/logging_airflow-3.0.1_openshift-false_executor-kubernetes (349.52s)
        --- PASS: kuttl/harness/cluster-operation_airflow-latest-3.0.1_openshift-false (278.74s)
        --- PASS: kuttl/harness/orphaned-resources_airflow-latest-3.0.1_openshift-false (175.52s)
        --- PASS: kuttl/harness/smoke_airflow-3.0.1_openshift-false_executor-kubernetes (239.95s)
        --- PASS: kuttl/harness/resources_airflow-latest-3.0.1_openshift-false (172.78s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.0.1_ldap-authentication-insecure-tls_openshift-false_executor-celery (283.57s)
        --- PASS: kuttl/harness/mount-dags-configmap_airflow-latest-3.0.1_openshift-false_executor-kubernetes (216.26s)
        --- PASS: kuttl/harness/mount-dags-configmap_airflow-latest-3.0.1_openshift-false_executor-celery (178.78s)
PASS

@adwk67
Copy link
Member

adwk67 commented Jun 4, 2025

Also ran the tests locally for 2.10.4 to check that the OOMs are dealt with by the increase in default resources in the latest operator code:

--- PASS: kuttl (847.76s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_airflow-2.10.4_openshift-false_executor-celery (229.72s)
        --- PASS: kuttl/harness/logging_airflow-2.10.4_openshift-false_executor-kubernetes (363.83s)
        --- PASS: kuttl/harness/external-access_airflow-2.10.4_openshift-false_executor-kubernetes (203.52s)
        --- PASS: kuttl/harness/external-access_airflow-2.10.4_openshift-false_executor-celery (203.75s)
        --- PASS: kuttl/harness/logging_airflow-2.10.4_openshift-false_executor-celery (423.88s)
        --- PASS: kuttl/harness/smoke_airflow-2.10.4_openshift-false_executor-kubernetes (210.43s)
PASS

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 41c8ff1 Jun 4, 2025
17 checks passed
@lfrancke lfrancke deleted the feat/hardcoded-uid-gid branch June 4, 2025 20:44
@lfrancke lfrancke moved this from Development: In Review to Development: Done in Stackable Engineering Jun 6, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants