Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

chore: add override integration tests #120

Merged
merged 2 commits into from
Aug 27, 2024
Merged

chore: add override integration tests #120

merged 2 commits into from
Aug 27, 2024

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Aug 26, 2024

Description

Part of stackabletech/issues#548

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@xeniape xeniape self-assigned this Aug 27, 2024
@xeniape xeniape requested a review from a team August 27, 2024 06:22
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xeniape xeniape added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit c1249eb Aug 27, 2024
31 checks passed
@xeniape xeniape deleted the fix/overrides branch August 27, 2024 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants