Skip to content

[Merged by Bors] - Renamed getting-started.sh -> getting_started.sh #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Renamed getting-started.sh -> getting_started.sh #561

wants to merge 4 commits into from
+42 −38

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Feb 22, 2023 •
edited
Loading

Description

Test doesn't work yet, but the renaming and test adaptions work on a custom cluster/locally.

Follow up ticket: #569

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Sorry, something went wrong.

@fhennig fhennig mentioned this pull request Mar 9, 2023
Closed
19 tasks
sbernauer
sbernauer approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhennig
Copy link
Contributor Author

fhennig commented Mar 21, 2023

bors merge

bors bot pushed a commit that referenced this pull request Mar 21, 2023
Renamed getting-started.sh -> getting_started.sh (#561)
18f7415 
# Description

Test doesn't work _yet_, but the renaming and test adaptions work on a custom cluster/locally.

Follow up ticket: #569
@bors
Copy link
Contributor

bors bot commented Mar 21, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Renamed getting-started.sh -> getting_started.sh [Merged by Bors] - Renamed getting-started.sh -> getting_started.sh Mar 21, 2023
@bors bors bot closed this Mar 21, 2023
@bors bors bot deleted the docs/getting-started-rename branch March 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fhennig @sbernauer