Skip to content

feat(stackable-operator): Add git-sync support #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
May 20, 2025
Merged

feat(stackable-operator): Add git-sync support #1024

merged 24 commits into from
May 20, 2025

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented May 7, 2025 •
edited
Loading

Description

Add git-sync support

Currently used in:

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@siegfriedweber siegfriedweber self-assigned this May 7, 2025
@siegfriedweber siegfriedweber mentioned this pull request May 7, 2025
Closed
6 tasks
@siegfriedweber siegfriedweber marked this pull request as ready for review May 8, 2025 14:31
@siegfriedweber siegfriedweber requested a review from a team May 8, 2025 14:31
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering May 8, 2025
@Techassi Techassi self-requested a review May 8, 2025 14:31
sbernauer
sbernauer reviewed May 9, 2025
View reviewed changes
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 9, 2025
@Techassi Techassi changed the title Add git-sync support feat(stackable-operator): Add git-sync support May 9, 2025
Techassi
Techassi requested changes May 9, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First initial (partial, I didn't look at the unit tests yet) review.

siegfriedweber and others added 15 commits May 13, 2025 21:11
@siegfriedweber
Add logging support to git-sync containers
6619fe4
@siegfriedweber
Use the type Url for the git-sync repository URL
5bba49d
@siegfriedweber
Extend the comment of the GitSync structure
e8ad04b
@siegfriedweber @Techassi
Improve a comment in the GitSync structure
2cf42ff 
Co-authored-by: Techassi <[email protected]>
@siegfriedweber
Extend the comment of the GitSync structure
80c75f6
@siegfriedweber
Merge branch 'feat/git-sync' of github.com:stackabletech/operator-rs …
d04e4e9 
…into feat/git-sync
@siegfriedweber @Techassi
Reformat the code
7dc7926 
Co-authored-by: Techassi <[email protected]>
@siegfriedweber @Techassi
Improve the code style
84aa733 
Co-authored-by: Techassi <[email protected]>
@siegfriedweber @Techassi
Improve the code style
d8a8b45 
Co-authored-by: Techassi <[email protected]>
@siegfriedweber @Techassi
Improve the code style
8a13bba 
Co-authored-by: Techassi <[email protected]>
@siegfriedweber @Techassi
Improve the code style
ea4e63f 
Co-authored-by: Techassi <[email protected]>
@siegfriedweber
Add always the git-sync parameter one-time
dccf07d
@siegfriedweber
Merge branch 'feat/git-sync' of github.com:stackabletech/operator-rs …
b3e460e 
…into feat/git-sync
@siegfriedweber @Techassi
Improve the code style
c69b2d2 
Co-authored-by: Techassi <[email protected]>
@siegfriedweber
Improve the code style
a2baa65
adwk67
adwk67 previously approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with gitsync tests from stackabletech/airflow-operator#623. LGTM.

@siegfriedweber siegfriedweber enabled auto-merge May 20, 2025 13:26
@siegfriedweber siegfriedweber added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 5d837cc May 20, 2025
8 checks passed
@siegfriedweber siegfriedweber deleted the feat/git-sync branch May 20, 2025 13:33
@Techassi Techassi mentioned this pull request May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer left review comments

@adwk67 adwk67 adwk67 approved these changes

@Techassi Techassi Techassi approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siegfriedweber @adwk67 @Techassi @sbernauer