Add loadBalancerClass field to ListenerClass.spec #986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See stackabletech/listener-operator#285, part of stackabletech/listener-operator#288
This PR adds a two new fields to ListenerClass:
Which are mapped to
Service.spec.{loadBalancerClass,allocateLoadBalancerNodePorts}
, respectively. Currently these are ignored unlessserviceType: LoadBalancer
; in v1alpha2,serviceType
should be turned into a rich enum instead, and these fields be moved into it, like so:Definition of Done Checklist
Author
Reviewer
Acceptance