Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadBalancerClass field to ListenerClass.spec #986

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Mar 19, 2025

Description

See stackabletech/listener-operator#285, part of stackabletech/listener-operator#288

This PR adds a two new fields to ListenerClass:

spec:
  loadBalancerClass: foo
  loadBalancerAllocateNodePorts: true

Which are mapped to Service.spec.{loadBalancerClass,allocateLoadBalancerNodePorts}, respectively. Currently these are ignored unless serviceType: LoadBalancer; in v1alpha2, serviceType should be turned into a rich enum instead, and these fields be moved into it, like so:

spec:
  serviceType:
    loadBalancer:
      loadBalancerClass: foo
      allocateNodePorts: true

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@nightkr
Copy link
Member Author

nightkr commented Mar 19, 2025

Moving the CRD changes into RFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant