Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template/ci): Use local rustfmt hook #483

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix(template/ci): Use local rustfmt hook #483

merged 2 commits into from
Feb 4, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Feb 4, 2025 •
edited
Loading

This fixes the rustfmt pre-commit hook introduced in #477. Pre-commit tries to run RUSTUP_TOOLCHAIN=nightly-2025-01-15 instead of cargo fmt, see CI run.

@Techassi Techassi self-assigned this Feb 4, 2025
@Techassi Techassi enabled auto-merge February 4, 2025 08:57
@Techassi Techassi mentioned this pull request Feb 4, 2025
Merged
NickLarsenNZ
NickLarsenNZ approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 9001281 Feb 4, 2025
2 checks passed
@Techassi Techassi deleted the fix/template-pre-commit-rustfmt-hook branch February 4, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

@razvan razvan Awaiting requested review from razvan

@sbernauer sbernauer Awaiting requested review from sbernauer

Assignees

@Techassi Techassi

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @NickLarsenNZ