Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote reviewdog to a PR check #553

Closed
wants to merge 4 commits into from
+4 −3
Closed

Demote reviewdog to a PR check #553

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
379f9a9
Demote reviewdog to a check, not review
nightkr Oct 24, 2024
27da64c
Intentionally break the build
nightkr Oct 24, 2024
64f6457
Disable rust cache?
nightkr Oct 24, 2024
08afb21
Pick up all Clippy errors, not just for modified lines
nightkr Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
@@ -162,8 +162,9 @@ jobs:
if: env.GITHUB_TOKEN != null
with:
clippy_flags: --all-targets -- -D warnings
reporter: 'github-pr-review'
github_token: ${{ secrets.GITHUB_TOKEN }}
fail_on_error: true
filter_mode: nofilter
- name: Run clippy manually without annotations
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4 changes: 2 additions & 2 deletions rust/operator-binary/src/main.rs
View file
Original file line number Diff line number Diff line change
@@ -37,8 +37,8 @@
include!(concat!(env!("OUT_DIR"), "/built.rs"));
}

pub const APP_PORT: u16 = 8088;
pub const OPERATOR_NAME: &str = "superset.stackable.tech";
// pub const APP_PORT: u16 = 8088;
// pub const OPERATOR_NAME: &str = "superset.stackable.tech";

#[derive(Parser)]
#[clap(about, author)]
@@ -81,7 +81,7 @@
])?;

let client = stackable_operator::client::initialize_operator(
Some(OPERATOR_NAME.to_string()),

Check failure on line 84 in rust/operator-binary/src/main.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/main.rs#L84 

error[E0425]: cannot find value `OPERATOR_NAME` in this scope
  --> rust/operator-binary/src/main.rs:84:22
   |
84 |                 Some(OPERATOR_NAME.to_string()),
   |                      ^^^^^^^^^^^^^ not found in this scope
Raw output 
rust/operator-binary/src/main.rs:84:22:e:error[E0425]: cannot find value `OPERATOR_NAME` in this scope
  --> rust/operator-binary/src/main.rs:84:22
   |
84 |                 Some(OPERATOR_NAME.to_string()),
   |                      ^^^^^^^^^^^^^ not found in this scope


__END__

Check failure on line 84 in rust/operator-binary/src/main.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/main.rs#L84 

error[E0425]: cannot find value `OPERATOR_NAME` in this scope
  --> rust/operator-binary/src/main.rs:84:22
   |
84 |                 Some(OPERATOR_NAME.to_string()),
   |                      ^^^^^^^^^^^^^ not found in this scope
Raw output 
rust/operator-binary/src/main.rs:84:22:e:error[E0425]: cannot find value `OPERATOR_NAME` in this scope
  --> rust/operator-binary/src/main.rs:84:22
   |
84 |                 Some(OPERATOR_NAME.to_string()),
   |                      ^^^^^^^^^^^^^ not found in this scope


__END__
&cluster_info_opts,
)
.await?;
@@ -125,7 +125,7 @@
.map(|res| {
report_controller_reconciled(
&client,
&format!("{SUPERSET_CONTROLLER_NAME}.{OPERATOR_NAME}"),

Check failure on line 128 in rust/operator-binary/src/main.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/main.rs#L128 

error[E0425]: cannot find value `OPERATOR_NAME` in this scope
   --> rust/operator-binary/src/main.rs:128:63
    |
128 |                         &format!("{SUPERSET_CONTROLLER_NAME}.{OPERATOR_NAME}"),
    |                                                               ^^^^^^^^^^^^^ not found in this scope
Raw output 
rust/operator-binary/src/main.rs:128:63:e:error[E0425]: cannot find value `OPERATOR_NAME` in this scope
   --> rust/operator-binary/src/main.rs:128:63
    |
128 |                         &format!("{SUPERSET_CONTROLLER_NAME}.{OPERATOR_NAME}"),
    |                                                               ^^^^^^^^^^^^^ not found in this scope


__END__

Check failure on line 128 in rust/operator-binary/src/main.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/main.rs#L128 

error[E0425]: cannot find value `OPERATOR_NAME` in this scope
   --> rust/operator-binary/src/main.rs:128:63
    |
128 |                         &format!("{SUPERSET_CONTROLLER_NAME}.{OPERATOR_NAME}"),
    |                                                               ^^^^^^^^^^^^^ not found in this scope
Raw output 
rust/operator-binary/src/main.rs:128:63:e:error[E0425]: cannot find value `OPERATOR_NAME` in this scope
   --> rust/operator-binary/src/main.rs:128:63
    |
128 |                         &format!("{SUPERSET_CONTROLLER_NAME}.{OPERATOR_NAME}"),
    |                                                               ^^^^^^^^^^^^^ not found in this scope


__END__
&res,
)
});
@@ -186,7 +186,7 @@
.map(|res| {
report_controller_reconciled(
&client,
&format!("{DRUID_CONNECTION_CONTROLLER_NAME}.{OPERATOR_NAME}"),

Check failure on line 189 in rust/operator-binary/src/main.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/main.rs#L189 

error[E0425]: cannot find value `OPERATOR_NAME` in this scope
   --> rust/operator-binary/src/main.rs:189:71
    |
189 |                         &format!("{DRUID_CONNECTION_CONTROLLER_NAME}.{OPERATOR_NAME}"),
    |                                                                       ^^^^^^^^^^^^^ not found in this scope
Raw output 
rust/operator-binary/src/main.rs:189:71:e:error[E0425]: cannot find value `OPERATOR_NAME` in this scope
   --> rust/operator-binary/src/main.rs:189:71
    |
189 |                         &format!("{DRUID_CONNECTION_CONTROLLER_NAME}.{OPERATOR_NAME}"),
    |                                                                       ^^^^^^^^^^^^^ not found in this scope


__END__

Check failure on line 189 in rust/operator-binary/src/main.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/main.rs#L189 

error[E0425]: cannot find value `OPERATOR_NAME` in this scope
   --> rust/operator-binary/src/main.rs:189:71
    |
189 |                         &format!("{DRUID_CONNECTION_CONTROLLER_NAME}.{OPERATOR_NAME}"),
    |                                                                       ^^^^^^^^^^^^^ not found in this scope
Raw output 
rust/operator-binary/src/main.rs:189:71:e:error[E0425]: cannot find value `OPERATOR_NAME` in this scope
   --> rust/operator-binary/src/main.rs:189:71
    |
189 |                         &format!("{DRUID_CONNECTION_CONTROLLER_NAME}.{OPERATOR_NAME}"),
    |                                                                       ^^^^^^^^^^^^^ not found in this scope


__END__
&res,
)
});

Unchanged files with check annotations Beta

View file
rust/operator-binary/src/operations/pdb.rs
};
use stackable_superset_crd::{SupersetCluster, SupersetRole, APP_NAME};
use crate::{superset_controller::SUPERSET_CONTROLLER_NAME, OPERATOR_NAME};

Check failure on line 8 in rust/operator-binary/src/operations/pdb.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/operations/pdb.rs#L8 

error[E0432]: unresolved import `crate::OPERATOR_NAME`
 --> rust/operator-binary/src/operations/pdb.rs:8:60
  |
8 | use crate::{superset_controller::SUPERSET_CONTROLLER_NAME, OPERATOR_NAME};
  |                                                            ^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root
Raw output 
rust/operator-binary/src/operations/pdb.rs:8:60:e:error[E0432]: unresolved import `crate::OPERATOR_NAME`
 --> rust/operator-binary/src/operations/pdb.rs:8:60
  |
8 | use crate::{superset_controller::SUPERSET_CONTROLLER_NAME, OPERATOR_NAME};
  |                                                            ^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root


__END__

Check failure on line 8 in rust/operator-binary/src/operations/pdb.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/operations/pdb.rs#L8 

error[E0432]: unresolved import `crate::OPERATOR_NAME`
 --> rust/operator-binary/src/operations/pdb.rs:8:60
  |
8 | use crate::{superset_controller::SUPERSET_CONTROLLER_NAME, OPERATOR_NAME};
  |                                                            ^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root
Raw output 
rust/operator-binary/src/operations/pdb.rs:8:60:e:error[E0432]: unresolved import `crate::OPERATOR_NAME`
 --> rust/operator-binary/src/operations/pdb.rs:8:60
  |
8 | use crate::{superset_controller::SUPERSET_CONTROLLER_NAME, OPERATOR_NAME};
  |                                                            ^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root


__END__
#[derive(Snafu, Debug)]
pub enum Error {
View file
rust/operator-binary/src/superset_controller.rs
extend_config_map_with_log_config, resolve_vector_aggregator_address, LOG_CONFIG_FILE,
},
util::build_recommended_labels,
APP_PORT, OPERATOR_NAME,

Check failure on line 86 in rust/operator-binary/src/superset_controller.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/superset_controller.rs#L86 

error[E0432]: unresolved imports `crate::APP_PORT`, `crate::OPERATOR_NAME`
  --> rust/operator-binary/src/superset_controller.rs:86:5
   |
86 |     APP_PORT, OPERATOR_NAME,
   |     ^^^^^^^^  ^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root
   |     |
   |     no `APP_PORT` in the root
Raw output 
rust/operator-binary/src/superset_controller.rs:86:5:e:error[E0432]: unresolved imports `crate::APP_PORT`, `crate::OPERATOR_NAME`
  --> rust/operator-binary/src/superset_controller.rs:86:5
   |
86 |     APP_PORT, OPERATOR_NAME,
   |     ^^^^^^^^  ^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root
   |     |
   |     no `APP_PORT` in the root


__END__

Check failure on line 86 in rust/operator-binary/src/superset_controller.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/superset_controller.rs#L86 

error[E0432]: unresolved imports `crate::APP_PORT`, `crate::OPERATOR_NAME`
  --> rust/operator-binary/src/superset_controller.rs:86:5
   |
86 |     APP_PORT, OPERATOR_NAME,
   |     ^^^^^^^^  ^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root
   |     |
   |     no `APP_PORT` in the root
Raw output 
rust/operator-binary/src/superset_controller.rs:86:5:e:error[E0432]: unresolved imports `crate::APP_PORT`, `crate::OPERATOR_NAME`
  --> rust/operator-binary/src/superset_controller.rs:86:5
   |
86 |     APP_PORT, OPERATOR_NAME,
   |     ^^^^^^^^  ^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root
   |     |
   |     no `APP_PORT` in the root


__END__
};
pub const SUPERSET_CONTROLLER_NAME: &str = "supersetcluster";
View file
rust/operator-binary/src/util.rs
use crate::OPERATOR_NAME;

Check failure on line 1 in rust/operator-binary/src/util.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/util.rs#L1 

error[E0432]: unresolved import `crate::OPERATOR_NAME`
 --> rust/operator-binary/src/util.rs:1:5
  |
1 | use crate::OPERATOR_NAME;
  |     ^^^^^^^^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root
Raw output 
rust/operator-binary/src/util.rs:1:5:e:error[E0432]: unresolved import `crate::OPERATOR_NAME`
 --> rust/operator-binary/src/util.rs:1:5
  |
1 | use crate::OPERATOR_NAME;
  |     ^^^^^^^^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root


__END__

Check failure on line 1 in rust/operator-binary/src/util.rs

GitHub Actions / clippy

[clippy] rust/operator-binary/src/util.rs#L1 

error[E0432]: unresolved import `crate::OPERATOR_NAME`
 --> rust/operator-binary/src/util.rs:1:5
  |
1 | use crate::OPERATOR_NAME;
  |     ^^^^^^^^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root
Raw output 
rust/operator-binary/src/util.rs:1:5:e:error[E0432]: unresolved import `crate::OPERATOR_NAME`
 --> rust/operator-binary/src/util.rs:1:5
  |
1 | use crate::OPERATOR_NAME;
  |     ^^^^^^^^^^^^^^^^^^^^ no `OPERATOR_NAME` in the root


__END__
use stackable_operator::k8s_openapi::api::batch::v1::Job;
use stackable_operator::kvp::ObjectLabels;
use stackable_superset_crd::APP_NAME;