Skip to content

Listener: Use headless and metrics service #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 4, 2025
Merged

Listener: Use headless and metrics service #644

merged 8 commits into from
Jul 4, 2025

Conversation

Maleware
Copy link
Member

@Maleware Maleware commented Jul 3, 2025

Description

This PR adopts superset according to https://github.com/stackabletech/decisions/issues/54#issue-3110829918

Additionally this adds listener functions to listener.rs and moves service_ports() and metrics_ports() to SupersetCluster as a method.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@Maleware Maleware self-assigned this Jul 3, 2025
@Maleware Maleware moved this to Development: In Progress in Stackable Engineering Jul 3, 2025
@Maleware Maleware moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jul 3, 2025
@Maleware
Copy link
Member Author

Maleware commented Jul 3, 2025

@maltesander maltesander self-requested a review July 3, 2025 15:41
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 3, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Maleware Maleware added this pull request to the merge queue Jul 4, 2025
Merged via the queue into main with commit 5807c4a Jul 4, 2025
17 checks passed
@Maleware Maleware deleted the fix/adopt-svcs branch July 4, 2025 14:45
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 7, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants