Skip to content

chore: Add CRD versioning #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 25, 2025
Merged

chore: Add CRD versioning #917

merged 11 commits into from
Feb 25, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Feb 7, 2025

Description

Part of stackabletech/issues#642

--- PASS: kuttl (323.58s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/cluster-operation_zookeeper-latest-3.9.2_openshift-false (55.30s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.2_use-server-tls-false_use-client-auth-tls-false_openshift-false (124.10s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.2_use-server-tls-true_use-client-auth-tls-false_openshift-false (136.80s)
        --- PASS: kuttl/harness/logging_zookeeper-3.9.2_openshift-false (89.80s)
        --- PASS: kuttl/harness/delete-rolegroup_zookeeper-3.9.2_openshift-false (59.82s)
        --- PASS: kuttl/harness/znode_zookeeper-latest-3.9.2_openshift-false (27.98s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.2_use-server-tls-false_use-client-auth-tls-true_openshift-false (76.06s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.9.2_use-server-tls-true_use-client-auth-tls-true_openshift-false (186.77s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@xeniape xeniape self-assigned this Feb 7, 2025
@xeniape xeniape marked this pull request as ready for review February 10, 2025 18:39
@razvan razvan self-requested a review February 12, 2025 13:45
razvan
razvan previously approved these changes Feb 12, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

NickLarsenNZ

This comment was marked as resolved.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit b84bcf4 Feb 25, 2025
17 checks passed
@xeniape xeniape deleted the chore/add-crd-versioning branch February 25, 2025 08:26
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants