Synchronise 2025.1 with upstream #133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use_keys needs to be True for netmiko to attempt public key authentication with the specified key_file. Change-Id: Ic0b2c921af91e667dd95fa174a3e47ddaf37f438 (cherry picked from commit dc96c86)
Convert port/timeout options from str to int/float, fixing type errors raised by ConnectHandler. Closes-Bug: #2110111 Change-Id: I9a4a1f857d2ace7c87cfbd6ed56356c1ed227caf Signed-off-by: Afonne-CID <[email protected]> (cherry picked from commit d26adb8)
When unplugging a bond from a network with trunk subports, the code was incorrectly using ADD_NETWORK_TO_BOND_TRUNK instead of DELETE_NETWORK_ON_BOND_TRUNK for removing subports from the bond trunk. This caused subports to be added instead of removed during bond cleanup. Fixes the logic to use the correct command for removing subports from bond trunks during network unplug operations. Closes-Bug: #2122025 Change-Id: Ieb01a5b8910b7d3e24ccf2561524f36bbd24b2c5 Signed-off-by: Grzegorz Koper <[email protected]> (cherry picked from commit 26160cd)
github-actions
bot
added
automated
bbezak
approved these changes
Jan 15, 2026
Member
|
we need that first - https://review.opendev.org/c/openstack/networking-generic-switch/+/973481 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2025.1 from upstream stable/2025.1.