Skip to content

Conversation

@Alex-Welsh
Copy link
Member

No description provided.

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner January 23, 2026 10:55
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly rotates the Zuul Tenks CI vault password and renames the secret for better clarity. The changes are consistent across the job definition, playbook, and secrets file. There is a suggestion to improve security by restricting permissions on the vault password file created on the runner.

@mnasiadka mnasiadka merged commit a72698c into stackhpc/2025.1 Jan 23, 2026
20 of 22 checks passed
@mnasiadka mnasiadka deleted the zuul-tenks-ci-pw branch January 23, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants