Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions zuul.d/secrets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,4 @@
- secret:
name: tenks_vault_password
data:
vault_pw: !encrypted/pkcs1-oaep
- M3rG9U0hY71HFOu6grSbwE1NT4BflOeJ86YKLnvrQRvGqUUVO5HO3rnIYiCg0No+MgCtj
XWSk8+FOKcy4tfUcdxv62T8ftykaL6B0l3vWFgGWcg1GlRjn8uLTYAbvYb8ehvBNGrW3k
4Pp+3xssAxvn3gKPL5f57dlFymth7yiBu38U2PWYX76DqxjdUQLkjp3g5sLoz10W8F9IX
aKyA8hdNRFxyEWysP/vzsXMoO8ZOlESbziMkRJ5wqCeg3PNtOWanf1ryhqCfKK3SJcVPP
shtERIADHOqBufKGRQSOn41iicMKcFkeYtZaaadxeHMm9KYbwT4YY43MFSVBTYFPkrMLQ
LPRTfJtq2cHveU64wAzCpteWeqfPQvs+hsVosNVF2S/4DbSCpMPOfjWpMobPlf3rc57oj
Lykgi/zL+9CEj/gOv4QeYpmM5f8CvngByahiBO5FTrFXzOanOHQOuGOyQR8MQtqj+Edp3
bP5dzV3wpwHepeZDMPpUIhFXrp/6VVefQU5HwjJzaCiUooCAVCCV8cBsXqvNAhvNO1y41
cUVxFBYyCJ4JGIw1qMBPOSUnhY148xPTm9+4pD6HbR1K9NCbU7GoahFDz2jtRYjFRM401
YuwR7K8GRILFJ4zEbtlmwj4gMUEZSo0HE0BZPUWSZpmFs1wX5LAKenMJs0Ctpg=
vault_pw: "none"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Using a common string like 'none' as a dummy password can be a security risk, even in a CI environment. If any resources created during the CI run are inadvertently exposed, they would be protected by a very weak and guessable password. It is a better practice to use a more complex, non-guessable string to mitigate this risk, even if it's not treated as a true secret.

      vault_pw: "dummy-ci-password-not-a-secret"

Loading