Reset job attempts counter when retrying failed jobs via queue:retry.

[binzram]

Hey there

Just found this package yesterday, already migrated one app over and it's doing a wonderful job! ❤️ Thanks!

I ran into this behavior when artisan queue:retry is called: it reads the raw payload from failed_jobs and creates another task. The number of attempts is saved inside this payload (internal.attempts). The stored payload already has attempts at the maximum for the job, so the requeued task immediately throws MaxAttemptsExceededException on execution: Making queue:retry effectively "obsolete."

I found that pushRaw() is only called without $options['job'] in the retry case. So this is a bit of a wonky solution to tackle it, especially resetting it to zero... But thought why not share this :)

Cheers

[binzram]

class RetryFailedCloudTask extends Command
{
    protected $signature = 'cloudtasks:retry {id? : Failed job ID} {--all}';

    public function handle(): void
    {
        $query = DB::table('failed_jobs');

        if ($this->option('all')) {
            $jobs = $query->get();
        } else {
            $jobs = $query->where('id', $this->argument('id'))->get();
        }

        foreach ($jobs as $failed) {
            $payload = json_decode($failed->payload, true);
            // Reset attempts
            $payload['internal']['attempts'] = 0;

            app('queue')
                ->connection($failed->connection)
                ->pushRaw(json_encode($payload), $failed->queue);

            DB::table('failed_jobs')->where('id', $failed->id)->delete();

            $this->info("Retried job {$failed->id}: {$payload['displayName']}");
        }
    }
}

And my current workaround command.

[marickvantuil]

Thanks for the PR!! It's very useful to have this fixed!

I have cleaned it up a little bit by resetting the attempts before the job is added to the failed table. That does mean that existing jobs in the table have to be corrected manually, but this way it keeps the package code a bit more straightforward. What do you think?