This repository was archived by the owner on May 6, 2025. It is now read-only.
Support parallel lookups #23
Merged
+362
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minder Vulnerability Report ✅Minder analyzed this PR and found no vulnerable dependencies.
|
|
If you switch to gh.trustypkg.dev as an endpoint you should get more busy capacity. That's more means for CI jobs. |
JAORMX
previously approved these changes
Jul 25, 2024
puerco
commented
Aug 2, 2024
| "github.com/stacklok/trusty-sdk-go/pkg/types" | ||
| ) | ||
|
|
||
| const ( | ||
| defaultEndpoint = "https://api.trustypkg.dev" | ||
| defaultEndpoint = "https://gh.trustypkg.dev" |
There was a problem hiding this comment.
@JAORMX switched to the gh endpoint ^
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit modifies the client to perform its requests using sig releases http agent which supports retries and parallel requests. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
dmjb
approved these changes
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the internals of the trusty client to perform the API requests with
http.Agentfrom kubernetes sig release which supports retries and parallel requests.Right now the requests are capped are capped as the trusty API seems to reject more than two or three at a time but it's speeding up already (this is the trusty CLI):
This also adds a couple of functions to work with package URL directly in the client.
Updated the tests and added new ones for the parallel functions.