This repository was archived by the owner on May 6, 2025. It is now read-only.
Update Trusty API response types #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the trusty response type. The main goal is to read the sigstore provenance data from the new fields but other fields are now added to keep the types up to date.. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
puerco
force-pushed
the
update-trusty-response
branch
from
d0bdf44 to
d9c4a7e
Compare
JAORMX
approved these changes
Jul 25, 2024
yrobla
approved these changes
Jul 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the trusty response type. The main goal is to read the sigstore provenance data from the new fields but other fields are now added to keep the types up to date.
It seems we have an inconsistency in the time formats in the trusty response, I added the fields commented out and opened https://github.com/stacklok/trusty/issues/2117
Closes #25
/cc @yrobla