-
-
Notifications
You must be signed in to change notification settings - Fork 65
Add scene preferences #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stackotter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this refactor. Everything looks great; my requested changes are all minor
|
Tested locally and all seems to work well. I only tested with AppKitBackend, because the changes are all platform-agnostic. The application menu successfully gets updated on app state updates, and app-level state updates in general still work. |
stackotter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixed the merge conflict from merging the window behaviour modifiers PR and all looks good now. I'll merge once CI passes
This PR:
ScenePreferenceValuestype, which does exactly what it says on the tin_Appsomewhat to accommodate this change