Skip to content

Conversation

@kaascevich
Copy link
Contributor

This PR:

  • Adds a ScenePreferenceValues type, which does exactly what it says on the tin
  • Refactors the command system to use this type
  • Refactors _App somewhat to accommodate this change

Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this refactor. Everything looks great; my requested changes are all minor

@stackotter
Copy link
Owner

Tested locally and all seems to work well. I only tested with AppKitBackend, because the changes are all platform-agnostic.

The application menu successfully gets updated on app state updates, and app-level state updates in general still work.

Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed the merge conflict from merging the window behaviour modifiers PR and all looks good now. I'll merge once CI passes

@stackotter stackotter merged commit ac18bff into stackotter:main Jan 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants