ROX-29116: (fix) Use ARM GH action workflow runners for ARM builds

[robbycochran]

Description

Undo the revert with a fix for error of using a runtime computed value within a job matrix.

Re-enable changes from #2084 which was reverted. Now with fixes to github actions on these commits

Original Description:
Utilize newly added arm64 runners for github actions.

• Build arm64 images natively instead of using QEMU in all workflows
• Make arm64 builds, unit-tests, and integration tests run alongside x86_64 by default on PR workflows. Build time performance is slightly faster on ARM so it shouldn't increase total time to finish PR steps.
• Split and refactored the builder image job into a local and remote version

Checklist

• Investigated and inspected CI test results
• Updated documentation accordingly

Automated testing

• Added unit tests
• Added integration tests
• Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

[sourcery-ai]

Hey @robbycochran - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider extracting the creation of ansible/secrets.yml into a reusable component to avoid duplication between local and remote build jobs.

Here's what I looked at during the review

• 🟡 General issues: 3 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.51%. Comparing base (7e0101f) to head (b55bb64).
Report is 6 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2106      +/-   ##
==========================================
- Coverage   28.52%   28.51%   -0.01%     
==========================================
  Files          94       94              
  Lines        5757     5759       +2     
  Branches     2547     2547              
==========================================
  Hits         1642     1642              
- Misses       3393     3395       +2     
  Partials      722      722              

Flag	Coverage Δ
collector-unit-tests	28.51% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Molter73]

a runtime computed value within a job matrix.

GHA and its tiny little corner cases...

I would recommend adding the run-multiarch-builds label before merging to make sure power and Z build correctly.

[Molter73]

Not something we need to do as part of this PR, but it might be easier to create the excludes array in the init.yml workflow, then pass it in to the workflows that need it. We could probably replace the architectures input entirely, but that might require some jq magic for us to translate the JSON to strings in the manifest script. I'll look into it after this is merged if you want to ignore this comment.

[robbycochran]

Agree -- we could also do something similar to stackrox and create a single object with named matrix strategies: https://github.com/stackrox/stackrox/blob/master/.github/workflows/build.yaml#L28

[Molter73]

Ok, but can we use python instead of bash? Because that thing is ungodly with all the $(jq ...) in there

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-running-an-inline-python-script

[Molter73]

Changes LGTM! Just left a minor nitpick that you can ignore.

Looks like there was a CI failure creating a Z VM, I'd encourage having as green a CI as possible before merging, but the error seems unrelated to the changes.