ROX-29116: (fix) Use ARM GH action workflow runners for ARM builds #2106
Conversation
This reverts commit 61cd323.
robbycochran
force-pushed
the
rc-fix-exclude
branch
from
5f37929 to
2ec7e40
Compare
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @robbycochran - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the creation of
ansible/secrets.ymlinto a reusable component to avoid duplication between local and remote build jobs.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2106 +/- ##
==========================================
+ Coverage 28.40% 28.52% +0.11%
==========================================
Files 94 94
Lines 5717 5757 +40
Branches 2531 2547 +16
==========================================
+ Hits 1624 1642 +18
- Misses 3383 3393 +10
- Partials 710 722 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| - name: Check arches for local build | ||
| if: ${{ ! contains(inputs.architectures, 'ppc64le') }} | ||
| id: arch | ||
| run: echo "local-exclude=[{\"arch\":\"ppc64le\"}]" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Not something we need to do as part of this PR, but it might be easier to create the excludes array in the init.yml workflow, then pass it in to the workflows that need it. We could probably replace the architectures input entirely, but that might require some jq magic for us to translate the JSON to strings in the manifest script. I'll look into it after this is merged if you want to ignore this comment.
There was a problem hiding this comment.
Agree -- we could also do something similar to stackrox and create a single object with named matrix strategies: https://github.com/stackrox/stackrox/blob/master/.github/workflows/build.yaml#L28
There was a problem hiding this comment.
Ok, but can we use python instead of bash? Because that thing is ungodly with all the $(jq ...) in there
robbycochran
force-pushed
the
rc-fix-exclude
branch
from
9aa0938 to
014e5b9
Compare
robbycochran
changed the title
Co-authored-by: Mauro Ezequiel Moltrasio <[email protected]>
Description
This reverts the original revert and fixes the error of using a runtime computed value within a job matrix.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.