Skip to content

ROX-29078: switch to per component service account #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

tommartensen
Copy link
Contributor

Description

Announcement: https://groups.google.com/a/redhat.com/g/konflux-announce/c/NxOyzi8wGxo/m/QXRGc1QqCQAJ

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Passing Konflux pipeline

@tommartensen tommartensen self-assigned this May 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.52%. Comparing base (48a8958) to head (18a1c45).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2120   +/-   ##
=======================================
  Coverage   28.52%   28.52%           
=======================================
  Files          94       94           
  Lines        5757     5757           
  Branches     2547     2547           
=======================================
  Hits         1642     1642           
  Misses       3393     3393           
  Partials      722      722           
Flag Coverage Δ
collector-unit-tests 28.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommartensen tommartensen marked this pull request as ready for review May 12, 2025 13:52
@tommartensen tommartensen requested a review from a team as a code owner May 12, 2025 13:52
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tommartensen - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tommartensen tommartensen added backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 labels May 13, 2025
@tommartensen tommartensen merged commit 9a23dcf into master May 14, 2025
95 of 106 checks passed
@tommartensen tommartensen deleted the tm/ROX-29078-switch-per-component-sa branch May 14, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants