Skip to content

chore(konflux): undo whitespace changes #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tommartensen
Copy link
Contributor

Description

An automated Mintmaker PR introduced some whitespace changes that this PR undoes.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Konflux pipelines start.

@tommartensen tommartensen marked this pull request as ready for review August 4, 2025 08:56
@tommartensen tommartensen requested review from rhacs-bot and a team as code owners August 4, 2025 08:56
@@ -66,11 +71,13 @@ spec:
name: output-tag-suffix
type: string
- default: .
description: Path to the source code of an application's component from where to build image.
description: Path to the source code of an application's component from where
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this description is a multiline while 115th line description is not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, just reverting the change from 194759f#diff-589d27b7d04635791151e8cbef7fcddcf17dd7300ed8d98948812fabdee347d6L74-L80

We have the same multi-line discrepancies on release branches. The formatting was generated by Misha applying his IDE defaults + personal taste, so I don't have much influence on this.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@ce83fb3). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2319   +/-   ##
=========================================
  Coverage          ?   28.83%           
=========================================
  Files             ?       96           
  Lines             ?     5799           
  Branches          ?     2551           
=========================================
  Hits              ?     1672           
  Misses            ?     3408           
  Partials          ?      719           
Flag Coverage Δ
collector-unit-tests 28.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants