-
Notifications
You must be signed in to change notification settings - Fork 19
New payment card, switching apps, direct URLs, and more #641
New payment card, switching apps, direct URLs, and more #641
Conversation
eb0fe30
to
6e93e58
Compare
6e93e58
to
b870dfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small things, otherwise this is great and a solid increase in code health.
stores/maker/reducer.js
Outdated
@@ -0,0 +1,61 @@ | |||
import { keyBy } from 'lodash' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, we've stuck to not importing helper libs like lodash
in the front-end, to keep bundle sizes low. Additionally, this import will import the entire lib, which we definitely don't need. Two options here:
-
Only import
lodash/keyBy
-
(Do this) look at you don't need lodash for an equivalent method if you need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did 1, and just notice you're pushing toward number 2.
Until app.co is at the level of maturity of having a test suite, wouldn't it better to use the lodash helper method, which itself is rigorously tested, than copy/pasting in a helper method with no tests or documentation?
6bfd734
to
2e94aff
Compare
7c16076
to
446c839
Compare
fix: CAN REBASE AMEND, Infer status from state feat: Infer status
Just gave this branch a look through. It seems like you pushed some half-finished code today, as the maker page doesn't build. It was just a few fixes to get it building, and I'm sure you just haven't pushed that yet. I also got the 'switching apps' functionality working, but it looks like it's not hydrating data yet. Nice work though, looking good overall! Let's please get this branch in a working state by the demo tomorrow, so we can use the Heroku build for others to play with. |
d0ef537
to
5224bad
Compare
5224bad
to
b2bf0e4
Compare
b2bf0e4
to
faca69f
Compare
b3b6fc3
to
5a63a74
Compare
…updated-maker-page Feature/payment details card updated maker page
setState()
method currently from parent componentcontent.js
file – I haven't seen this pattern followed elsewhere, but find it helps to focus on behaviour when visual noise is removedmaker/index.js
to a functional component@hstove as discussed, will use
useReducer
, but will do separately as this requires movingpages/maker/index.js
to a function component w/ hooks