This repository was archived by the owner on Mar 26, 2025. It is now read-only.
fix: accommodate for optional properties in index signature #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative to #86, which fixes the index signatures not supporting optional (
undefined) values.#86 modifies the
Jsontype addingundefinedto it, which may be considered not technically correct. This PR proposes an alternative way that doesn't touch theJsontype.Type of Change
Does this introduce a breaking change?
No.
Are documentation updates required?
No.
Testing information
Build the project and verify the TS compiler doesn't show errors in
decode.d.tsfor optional properties. Example:Checklist
npm run testpasses