This repository was archived by the owner on Dec 4, 2024. It is now read-only.
Draft
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
- Coverage 39.35% 39.16% -0.20%
==========================================
Files 45 45
Lines 5229 5273 +44
Branches 47 58 +11
==========================================
+ Hits 2058 2065 +7
- Misses 3170 3206 +36
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds the possibility to make withdrawal requests as Stacks transactions.
Fixes #250
Testing
Risks
This introduces new complexity for users and developers.
Users might mix up how they requested to withdraw.
Indexers might not track the requests correctly.
How were these changes tested?
For clarity, one unit test was added. More to come.
What future testing should occur?
More unit tests.
Checklist: