Skip to content

Fix trait reference enrichment edge case #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 10, 2025

Conversation

BowTiedRadone
Copy link
Collaborator

@BowTiedRadone BowTiedRadone commented Jul 9, 2025

This PR fixes an edge case in the trait reference enrichment process where Rendezvous was not able to correctly enrich a function interface having a first tuple trait reference parameter followed by a non-trait-reference tuple parameter.

Resolves #149.

This commit addresses an edge case in the trait reference enrichment process
where Rendezvous was not able to correctly enrich a function interface having
a first tuple trait reference parameter followed by a non-trait-reference tuple
parameter.
@BowTiedRadone BowTiedRadone requested a review from a team as a code owner July 9, 2025 14:18
@BowTiedRadone BowTiedRadone requested a review from moodmosaic July 9, 2025 14:19
Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 I left a comment about readability (and some nitpicks).

@BowTiedRadone BowTiedRadone merged commit 4dd7ea9 into master Jul 10, 2025
22 checks passed
@BowTiedRadone BowTiedRadone deleted the fix/trait-reference-detection branch July 10, 2025 13:11
@BowTiedRadone BowTiedRadone mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken trait implementation generation for self-listing-helper-v3a
2 participants