-
Notifications
You must be signed in to change notification settings - Fork 725
draft: marf testing #6739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
draft: marf testing #6739
Conversation
…ue if it's 0, store a bitmap and non-empty trie ptrs if the list is sparse, and store node patches atop full nodes (and read them back)
…then record the original node from which it was copied so that a TrieNodePatch can be calculated and stored instead
…oid repeating nodes across tries
… each node and see if we can instead patch an existing node instead of storing a (mostly-unchanged) copy
…ead due to a mismatch between cur_block and cur_block_id borne out of retargeting a trie
323ea93 to
95ef151
Compare
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (69.17%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6739 +/- ##
===========================================
- Coverage 78.18% 69.17% -9.02%
===========================================
Files 580 585 +5
Lines 361096 362757 +1661
===========================================
- Hits 282312 250925 -31387
- Misses 78784 111832 +33048
... and 281 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
It took me a few minutes to realize that this PR includes the compression PR. If this PR is only supposed to be adding new tests, can you instead base it on the compression PR instead of |
Yes, as stated in the PR description (and also shared during the sync and in the doc analysis), this PR is intended solely as a companion to the main PR (#6654). The only difference is that compression is enabled here. This allows us to run CI in both MARF compression configurations while developing the complete solution. I try to keep the two PRs aligned. Typically, I experiment and iterate in this PR and then port the finalized solution to the main one, so the main PR maintains a clean commit history. At the moment, they may be off by one commit, as the intent was to highlight the latest successful CI run with the Node patch fix. In short, this PR does not require a full review and primarily serves as supporting evidence. It will not be merged and will be closed once the MARF compression work is completed. That said, it can be used for on-demand review of specific pieces of code if something needs to be finalized before being ported to the main PR. |
aabe96a to
3192e1a
Compare
010a386 to
47b7963
Compare
Description
Companion PR for validating marf compression against CI
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo