-
Notifications
You must be signed in to change notification settings - Fork 725
test: abandon proposal and extend when new burn block arrives #6767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
test: abandon proposal and extend when new burn block arrives #6767
Conversation
A new integration test: - Miner wins tenure N - Miner mines tenure change block and one additional block in tenure N - Block validation is paused so the next block proposal cannot be accepted yet - Miner proposes block M - Next burn block, N+1 arrives, with no block commits, so no sortition winner - Unpause block validation, block M is accepted - Miner mines tenure extend in block M+1
|
Leaving this in draft until I add working variants of this test where:
|
Both testing additional scenarios with blocks mid-proposal while a new burn block arrives with no winner.
|
These tests all pass -- no troublesome scenarios discovered. |
hstove-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have conflicts unfortunately, but LGTM!
d78d9e8
|
I merged in develop and just had to fix a conflict in stacks-node/src/tests/signer/v0.rs, due to both branches adding new tests. @hstove-stacks @aaronb-stacks |
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (73.17%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6767 +/- ##
===========================================
- Coverage 77.52% 73.17% -4.36%
===========================================
Files 582 582
Lines 361565 361871 +306
===========================================
- Hits 280294 264786 -15508
- Misses 81271 97085 +15814
... and 260 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
A new integration test: