Skip to content

handle case where stx address is not available in deposits #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

hozzjss
Copy link
Contributor

@hozzjss hozzjss commented Apr 30, 2025

No description provided.

matteojug
matteojug previously approved these changes May 6, 2025
Copy link
Contributor

@matteojug matteojug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Diffing this with the withdrawal one, here we are missing the isConnected check. Do we want/need that check here as well?

@aldur aldur added this to the Bridge bugfixing milestone May 6, 2025
@aldur aldur added this to sBTC May 6, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC May 6, 2025
@aldur aldur merged commit 48e2307 into stacks-sbtc:main May 7, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in sBTC May 7, 2025
@hozzjss hozzjss deleted the fix/ledger-deposit branch May 7, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants