Skip to content

Reskin - v2 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Reskin - v2 #61

wants to merge 9 commits into from

Conversation

setbern
Copy link
Contributor

@setbern setbern commented Dec 16, 2024

This add the new design for the deposit and reclaim script with a placeholder view for history and withdraw
Captura de pantalla 2024-12-16 a la(s) 1 30 32 a m
Captura de pantalla 2024-12-16 a la(s) 1 30 49 a m
Captura de pantalla 2024-12-16 a la(s) 1 31 08 a m
Captura de pantalla 2024-12-16 a la(s) 1 31 22 a m
Captura de pantalla 2024-12-16 a la(s) 1 31 38 a m

This need extensive testing to ensure all error notification and success notifications are in order.

Ideally we can have a staging environment so we can test this in the wild without having to replace the production version.

This should not be merged in until we've tested

  • Deposit (Success)
  • Deposit (Failure)
    • Not enough funds
    • Emily out of sync
    • Signers down
    • Cap exceeded
  • Reclaim (Success)
  • Reclaim (Failure)
    • Locktime cap blocks not passed
    • transaction failure failed

@setbern setbern requested review from hozzjss and aldur December 16, 2024 06:37
@aldur
Copy link
Contributor

aldur commented Jan 30, 2025

Closing this. Please open small, incremental PRs for each component of the reskin.

@aldur aldur closed this Jan 30, 2025
@matteojug matteojug deleted the reskin branch April 2, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants