set up STAC metadata #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
approved these changes
Dec 24, 2024
kylebarron
left a comment
kylebarron
left a comment
There was a problem hiding this comment.
Overall this looks really good! I love the use of dataclasses and pystac
| PARTITION_FORMAT, | ||
| ) | ||
|
|
||
| COLLECTION_DESCRIPTION_FORMAT = ( |
There was a problem hiding this comment.
Nit: I'd suggest a multi line string to make this easier to read
COLLECTION_DESCRIPTION_FORMAT = """\
## Overture Maps - {theme}
This collection contains items for the {theme} theme.
{theme_description}
etc| def theme_description(self) -> str: | ||
| """Scrape theme description from OvertureMaps/docs repo""" | ||
| # Get the raw content | ||
| raw_url = f"https://raw.githubusercontent.com/OvertureMaps/docs/refs/heads/main/docs/guides/{self.theme.value}.mdx" |
There was a problem hiding this comment.
If this is mdx, there may be some elements that don't render correctly in standard markdown.
| ) | ||
|
|
||
| # version extension | ||
| VersionExtension.ext(item, add_if_missing=True) |
There was a problem hiding this comment.
Is this supposed to be assigned to something? Or does this have side-effects?
Comment on lines
+427
to
+430
| # set primary geometry type to first geometry_type in geoparquet metadata | ||
| item.ext.table.primary_geometry = self.geo_metadata["columns"]["geometry"][ | ||
| "geometry_types" | ||
| ][0] |
There was a problem hiding this comment.
If there's a list of multiple geometry types, you really can't just pick one. It could be a mix of polygon and multi polygon and you'll lose that information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First draft! I am so sorry for the monstrous line count but that's what I get for using pytest-recording and checking in the example json files.
Most of the interesting additions are in
metadata.pywhich has the logic for extracting the metadata from parquet files.You can browse the example metadata here: https://radiantearth.github.io/stac-browser/#/external/raw.githubusercontent.com/stactools-packages/overture-maps/feat/stac/examples/catalog.json
Checklist
scripts/test)