Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Access Control to wager contract #66

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Add Access Control to wager contract #66

merged 4 commits into from
Feb 17, 2025

Conversation

beeguy74
Copy link
Contributor

@beeguy74 beeguy74 commented Feb 16, 2025 •
edited
Loading

closes #21
integration OpenZeppelin access control into the wager contract

updates:

  • Modified the constructor to initialize the AccessControlComponent and grant the ADMIN_ROLE to a specified admin_contract.
  • Added a constant ADMIN_ROLE to uniquely identify the admin role.
  • Updated the set_escrow_address method, allowing only the admin to set the escrow address.
  • utils and test_wager were refactored to provide admin_address in the wager contract's constructor

image

@beeguy74 beeguy74 marked this pull request as ready for review February 16, 2025 14:02
@beeguy74
Copy link
Contributor Author

@manlikeHB hi, sir! PR is ready for review

@manlikeHB manlikeHB self-requested a review February 17, 2025 09:36
@manlikeHB
Copy link
Contributor

Thank you @beeguy74, LGTM!

@manlikeHB manlikeHB merged commit e535a6b into stakepoint:staging Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manlikeHB manlikeHB manlikeHB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Access Control to wager contract
2 participants
@beeguy74 @manlikeHB