Web3 7 #583
Web3 7 #583
Conversation
Signed-off-by: cyc60 <[email protected]>
Signed-off-by: cyc60 <[email protected]> # Conflicts: # poetry.lock
Signed-off-by: cyc60 <[email protected]>
Signed-off-by: cyc60 <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Upgrade codebase to newer web3 / dependency versions and adjust code to new snake_case APIs while adding proper client teardown.
- Migrate web3 event log and contract ABI calls to snake_case (fromBlock -> from_block, encodeABI -> encode_abi) and update middleware usage.
- Add explicit client disconnection utilities and integrate them into startup/shutdown flow.
- Refactor signature handling and add dependency version bumps (py-ecc, sw-utils, aiohttp).
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/validators/register_validators.py | Adjust signature argument to bytes conversion for contract calls. |
| src/validators/execution.py | Update event log parameter naming to new web3 snake_case API. |
| src/common/startup_check.py | Rework node wait loops, add disconnect calls, migrate event log params to snake_case. |
| src/common/credentials.py | Remove ThreadPoolExecutor hack and unused imports. |
| src/common/contracts.py | Update encode ABI invocation and event log param names. |
| src/common/clients.py | Replace deprecated signing middleware construction, add close_clients helper. |
| src/commands/start/base.py | Ensure clients are closed with try/finally around startup workflow. |
| pyproject.toml | Bump library versions (py-ecc, sw-utils, aiohttp) aligning with API changes. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: cyc60 <[email protected]>
Signed-off-by: cyc60 <[email protected]> # Conflicts: # poetry.lock # pyproject.toml # src/commands/consolidate.py # src/commands/start/base.py
Signed-off-by: cyc60 <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sentry-sdk = "==1.45.1" | ||
| py-ecc = "==6.0.0" | ||
| py-ecc = "==8.0.0" | ||
| gql = {extras = ["aiohttp"], version = "==3.5.0"} |
There was a problem hiding this comment.
The sw-utils version is being downgraded from v0.11.0 to v0.10.6. This is a backwards change that could break functionality or lose features. If this is intentional due to compatibility issues with Web3.py v7, it should be documented in the PR description or comments.
| gql = {extras = ["aiohttp"], version = "==3.5.0"} | |
| gql = {extras = ["aiohttp"], version = "==3.5.0"} | |
| # sw-utils is intentionally downgraded to v0.10.6 for compatibility with Web3.py v7. See PR description for details. |
No description provided.