Integrate phasePlannerStore for Enhanced Ticket Management and Websocket Support #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliraza556
force-pushed
the
feature-phase-planner-store-integration
branch
from
25f8418 to
99474bd
Compare
|
Hi @humansinstitute, Please review this PR. |
|
@humansinstitute Locally, Prettier passed, but I’m not sure why it failed in the CI/CD pipeline.
|
|
@humansinstitute, I noticed that sometimes different checks fail. Please see the details below: After some time, the issue seems to resolve automatically. I'm not sure how it gets fixed, but it does.
|
src/config/socket.ts
Outdated
There was a problem hiding this comment.
We're not looking to change the SOCKET_MSG in this change.
The plan is to keep this message and associated code in place. Out of scope change.
| @@ -63,6 +64,17 @@ const PhasePlannerView: React.FC = () => { | |||
| const sessionId = res.body; | |||
| console.log(`Websocket Session ID: ${sessionId}`); | |||
| } | |||
|
|
|||
| if (res.msg === SOCKET_MSG.ticket_update && res.body) { | |||
There was a problem hiding this comment.
This is not the approach we will be taking please remove. Out of Scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Chnages:
closes: #700
Issue ticket number and link:
Checklist before requesting a review