Skip to content

Laplace: move theta0 to tolerances #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 1, 2025
Merged

Conversation

WardBrian
Copy link
Member

Discussed in #3202 (comment), counterpart to stan-dev/stanc3#1521

Summary

Theta0 is now a tolerance parameter rather than required. When not provided, we assume a vector of 0s is sufficient.

This required a bit of re-organization to get the size right, but otherwise wasn't too bad because we call the covariance function pretty early and can get the size from the return of that function.

Tests

Existing tests updated

Side Effects

Release notes

Checklist

  • Copyright holder: (fill in copyright holder information)

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@charlesm93
Copy link
Contributor

@WardBrian Thanks for taking care of this. @SteveBronder, I feel like you're more familiar with the code at this point and can do this review more expeditiously, but let me know if you don't have the time and need me to jump in.

[ci skip]
@SteveBronder SteveBronder mentioned this pull request Jun 30, 2025
4 tasks
@WardBrian
Copy link
Member Author

Merged in the changes from #3213 @SteveBronder

@WardBrian
Copy link
Member Author

@SteveBronder mind looking at stan-dev/stanc3#1521? It needs to be merged at the same time as this

@WardBrian WardBrian merged commit f7ccc01 into develop Jul 1, 2025
33 of 34 checks passed
@WardBrian WardBrian deleted the laplace/move-theta-to-tols branch July 1, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants