Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expose_stan_functions flags for c++17 #1097

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Conversation

andrjohns
Copy link
Contributor

Summary:

expose_stan_functions fails under c++17 as the Rcpp plugin is missing the updated Boost flags. This is causing rstanarm test failures on CRAN: stan-dev/rstanarm#601

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@bgoodri
Copy link
Contributor

bgoodri commented Sep 29, 2023

This is needed, but I'm going to bump all of the C++14 stuff in rstan to C++17.

This means you cannot use Stan with R < 4.0 on Windows.
that was due to non-standard evaluation in ggplot2
@bgoodri bgoodri merged commit a6dd8d1 into develop Sep 30, 2023
7 checks passed
@bgoodri bgoodri deleted the fix-expose-failure branch September 30, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants