-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganization and encapsulation of the main program #10
base: main
Are you sure you want to change the base?
Conversation
added general description of contents
formatting
Hey @pikuch! Matt asked me to help with maintaining this repository, so I've been thinking about how to handle PRs like this. It's a tough one... your improvements are really nice, but it also changes the code significantly - and part of the purpose of this repo is to document the original code from the video. I've added some thoughts to the README about how to structure the code here going forward. With that in mind, would you be open to adding your wave effect to the examples folder, and then linking to the rest of your work under the "Further Work" section of the README? I think that's a sensible way forward - let me know if you agree. |
Hello! I realize my rewrite is quite drastic. Feel free to use any of the code, including adding the wave effect to the examples folder. |
It makes functions take a tree ( XmasTree or VirtualXmasTree) as an argument and use it to create patterns.