fix: get starknet v4
MetaMask detection
#274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MetaMask Detection and Provider Handling for get-starknet
This PR fixes the detection and handling of the MetaMask provider in the
get-starknet v4
integration, following the same strategy as in theget-starknet v3
implementation: provider logic detection happens in themetaMaskVirtualWallet.ts
.The
hasSupport
methods detects the provider and sets it as provider attribute in theobject
, so that when loading the wallet theprovider
does not need to be fetched again. If the provider is not set when loading then we try to load it again.This PR is required to finalise the
get-starknet v4
implementation on theStarkNet Snap
.