Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get starknet v4 MetaMask detection #274

Merged

Conversation

khanti42
Copy link
Contributor

Fix MetaMask Detection and Provider Handling for get-starknet

This PR fixes the detection and handling of the MetaMask provider in the get-starknet v4 integration, following the same strategy as in the get-starknet v3 implementation: provider logic detection happens in the metaMaskVirtualWallet.ts.

The hasSupport methods detects the provider and sets it as provider attribute in the object, so that when loading the wallet the provider does not need to be fetched again. If the provider is not set when loading then we try to load it again.

This PR is required to finalise the get-starknet v4 implementation on the StarkNet Snap.

@fracek
Copy link
Collaborator

fracek commented Oct 26, 2024

Looks good. Can you add a changeset with your PR so that I can make a release as soon as it's merged?

@khanti42
Copy link
Contributor Author

@fracek : just added the changeset!

@fracek fracek merged commit 997aaae into starknet-io:develop Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants