Skip to content

Conversation

@PhilippeR26
Copy link
Collaborator

Motivation and Resolution

Add handling of Starknet Wallets with get-starknet V5 library.

Usage related changes

Class WalletAccountV5 has been added.
Namespace walletV5 has been also added.
Detailed usage in the guide.

Development related changes

  • In package.json, add of "@wallet-standard/features" to get the type for events (not re-exported by get-starknet).
  • Add of "@starknet-io/get-starknet/wallet-standard/features". As get-starknet V5 is not yet released, exact import names are uncertain. That's why this PR is initially tagged as draft. To be finalized once get-starknet released.
  • Except events handling (only one event in get-starknet v5), few changes from V4.
  • As with WalletAccount V4, it's not possible to test V5 in test suite. Extensive tests will be performed once V5 released, prior to remove the draft tag of this PR.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes in code (API docs will be generated automatically)
  • All tests are passing

@PhilippeR26 PhilippeR26 changed the base branch from develop to beta July 21, 2025 14:07
@PhilippeR26 PhilippeR26 requested a review from tabaktoni July 21, 2025 16:25
@PhilippeR26 PhilippeR26 marked this pull request as ready for review July 25, 2025 09:37
@PhilippeR26
Copy link
Collaborator Author

get-starknet is no more beta, and is now v5.0.0.
We can now import type StandardEventsChangeProperties directly from get-starknet, without using @wallet-standard/features lib.
This last commit has been tested with success in the DAPP demo: https://cairo1-js.vercel.app/

@PhilippeR26 PhilippeR26 changed the base branch from develop to beta November 21, 2025 11:55
@PhilippeR26
Copy link
Collaborator Author

This get-starknet v5 PR has been re-based to beta.
@tabaktoni @penovicp : this PR has been tested with starknet v0.14.1 & rpc 0.10.0 in the demo DAPP. It's OK to merge in v9 beta

@PhilippeR26
Copy link
Collaborator Author

Screenshot_20251121-150309_Braavos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants