Skip to content

flow-control: Add cache node optimization. #8115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liorgold2
Copy link
Collaborator

@liorgold2 liorgold2 commented Aug 5, 2025

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/2789b93c branch from b7ee27c to 0a909b4 Compare August 5, 2025 19:25
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/edbf06d2 branch from 80b3efb to 95b9ca7 Compare August 5, 2025 19:25
@liorgold2 liorgold2 requested a review from orizi August 5, 2025 19:25
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)


crates/cairo-lang-lowering/src/lower/flow_control/create_graph/cache.rs line 12 at r1 (raw file):

/// identically.
pub struct Cache<Input> {
    cache: RefCell<UnorderedHashMap<Input, NodeId>>,

doc why refcell.

@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/edbf06d2 branch from 95b9ca7 to b1ca544 Compare August 7, 2025 20:03
@liorgold2 liorgold2 changed the base branch from pr/liorgold2/lior/flow-control/2789b93c to main August 7, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants